-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a configuration property for the observation patterns of Spring Integration components #33099
Provide a configuration property for the observation patterns of Spring Integration components #33099
Conversation
Spring Integration can instrument its component with an `Observation` according to the `@EnableIntegrationManagement.observationPatterns` value * Expose `spring.integration.management.observation-patterns` configuration property * Propagate this property into an `@EnableIntegrationManagement` in the `IntegrationAutoConfiguration.IntegrationManagementConfiguration` * Verify that property has an effect via `IntegrationAutoConfigurationTests.integrationManagementInstrumentedWithObservation()`
Considering this one a bug of omission, but we can't add it yet because we can't move to SNAPSHOTs before our next RC. |
No. This is not a bug or omission. Thanks |
By "bug of omission" I meant that it's a feature we should ideally have support for in the 3.0 release since the feature was added in Spring Integration 6. I guess you're right though, it's really an enhancement. I still think it might be worth adding to 3.0 if we can. It seems low risk. |
Sounds good, Phil! |
Spring Integration has introduced a new observationPatterns attribute on EnableIntegrationManagement. Spring Boot auto-configures EnableIntegrationManagement so this commit adds a property that allows users to configure the patterns without declaring the annotation themselves. See gh-33099
Spring Integration can instrument its component with an
Observation
according to the@EnableIntegrationManagement.observationPatterns
valuespring.integration.management.observation-patterns
configuration property@EnableIntegrationManagement
in theIntegrationAutoConfiguration.IntegrationManagementConfiguration
IntegrationAutoConfigurationTests.integrationManagementInstrumentedWithObservation()